Skip to content

DriverTool: add support for WebAssembly autolink entries #39502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

MaxDesiatov
Copy link
Contributor

This change adds support for .swift1_autolink_entries in WebAssembly object files to lib/DriverTool/autolink_extract_main.cpp. This is implemented in a similar way to existing ELF autolink entries handling.

Related to SR-9307.

@MaxDesiatov MaxDesiatov force-pushed the maxd/wasm-autolink-entries branch from 372793b to 2687bbf Compare September 29, 2021 09:13
@MaxDesiatov MaxDesiatov force-pushed the maxd/wasm-autolink-entries branch from 2687bbf to daceec9 Compare September 29, 2021 09:15
@MaxDesiatov
Copy link
Contributor Author

@swift-ci please smoke test

@MaxDesiatov
Copy link
Contributor Author

CC @kateinoigakukun

@MaxDesiatov
Copy link
Contributor Author

@swift-ci please test Windows platform

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rather unfortunate. Since WASM is still relatively new, I still think that we should consider just requiring LLD and falling back to the LLVM extensions.

@MaxDesiatov MaxDesiatov merged commit c52f37c into main Sep 29, 2021
@MaxDesiatov MaxDesiatov deleted the maxd/wasm-autolink-entries branch September 29, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants