Skip to content

[BuildScript] Don't install SwiftSyntax #39682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Oct 11, 2021

Companion of swiftlang/swift-syntax#323


Instead, link all binaries in the toolchain using SwiftSyntax (currently only sk-stress-test) should link to the binary statically. This simplifies the way SwiftSyntax is built and at the same time slightly reduces the toolchain size.

@ahoppen
Copy link
Member Author

ahoppen commented Oct 11, 2021

swiftlang/swift-syntax#323

@swift-ci Please smoke test

@ahoppen
Copy link
Member Author

ahoppen commented Oct 11, 2021

swiftlang/swift-syntax#323

@swift-ci Please build toolchain

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 6d5df8a4922f21c9cd8134bdc3e64c825a8d876b

Install command
tar zxf swift-PR-39682-702-ubuntu16.04.tar.gz
More info

Instead, link all binaries in the toolchain using SwiftSyntax (currently only `sk-stress-test`) should link to the binary statically. This simplifies the way SwiftSyntax is built and at the same time slightly reduces the toolchain size.
@ahoppen ahoppen force-pushed the pr/dont-install-swiftsyntax branch from 6d5df8a to fb7a5b8 Compare October 11, 2021 20:04
@ahoppen
Copy link
Member Author

ahoppen commented Oct 11, 2021

swiftlang/swift-syntax#323
@swift-ci Please smoke test

@ahoppen
Copy link
Member Author

ahoppen commented Oct 11, 2021

swiftlang/swift-syntax#323
@swift-ci Please build toolchain

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - fb7a5b8

Install command
tar zxf swift-PR-39682-703-ubuntu16.04.tar.gz
More info

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - fb7a5b8

Install command
tar -zxf swift-PR-39682-1173-osx.tar.gz --directory ~/

@ahoppen ahoppen requested a review from akyrtzi October 12, 2021 07:52
@ahoppen ahoppen merged commit 3bd6716 into swiftlang:main Oct 13, 2021
@ahoppen ahoppen deleted the pr/dont-install-swiftsyntax branch October 13, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants