Skip to content

[utils] Improve update_checkout on Windows #41556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[utils] Improve update_checkout on Windows #41556

wants to merge 2 commits into from

Conversation

stevapple
Copy link
Contributor

@stevapple stevapple commented Feb 25, 2022 •
edited
Loading

Force symlinks and autocrlf for cloning new Swift sources.

Resolves SR-NNNN.

compnerd
compnerd approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, but do get a second opinion from @gottesmm (I want to make sure that the line-ending changes do not interfere with others)

@stevapple stevapple mentioned this pull request Feb 28, 2022
Open
@stevapple
Copy link
Contributor Author

Anyone to review & merge?

@stevapple
Copy link
Contributor Author

It's a very tiny change — anyone to test and merge?

@stevapple stevapple changed the title [utils] Fix update_checkout for Windows [utils] Improve update_checkout on Windows Sep 20, 2022
@hamishknight
Copy link
Contributor

@swift-ci please test

@gottesmm
Copy link
Contributor

This needs a test.

@AnthonyLatsis AnthonyLatsis added the update-checkout Area → utils: the `update-checkout` script label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@gottesmm gottesmm Awaiting requested review from gottesmm

Assignees
No one assigned
Labels
update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stevapple @hamishknight @gottesmm @compnerd @AnthonyLatsis