[SILGen] Fix swift_once initializer signature for lazy global var
#42155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
78 tasks
kateinoigakukun
force-pushed
the
katei/fix-lazy-global-init-sig
branch
from
ca36240 to
ead1d19
Compare
|
@swift-ci Please test |
compnerd
reviewed
Apr 3, 2022
`Builtin.once` has type `(Builtin.RawPointer, (Builtin.RawPointer) -> ())` at Swift level, but lazy global init passes its initializer as `() -> ()`, so their callee and caller signatures doesn't match.
kateinoigakukun
force-pushed
the
katei/fix-lazy-global-init-sig
branch
from
ead1d19 to
1a75b08
Compare
|
@swift-ci Please test |
|
I think this should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builtin.oncehas type(Builtin.RawPointer, (Builtin.RawPointer) -> ())at Swift level, but lazy global init passes its initializer as
() -> (),so their callee and caller signatures doesn't match.
https://github.com/apple/swift/blob/f834a51ff57ea2514bfed18f1bc9aa33a875eaed/lib/AST/Builtins.cpp#L1837
This PR adds an explicit context argument to the initializer function implementation.
This is to avoid runtime crash in WebAssembly