SR-2280: swiftc -static-stdlib option fails on Linux #5269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any updates on this PR? CI checks seem to be stuck |
- Link in static version of libicu if available in preference to the dynamic library when using the -static-stdlib option.
|
@slavapestov Ive rebased this PR. A lot of the CMake changes have already gone in as part of #5394 so this PR just updates the |
|
LGTM. |
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the -static-stdlib option on linux/ELF platforms link in more static libraries where possible to produce binaries that arent dependant on libraries not installed by default. Currently this is just libicu.a, libicui18n.a and libicudata.a if these can be found
Resolves SR-2280
list in ToolChains.cpp for use by -static-stdlib option
ones for packages not normally installed by default,
eg libicu