[Tests] Make OS features consistent #58975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
force-pushed
the
make-features-consistent
branch
from
b01c6a4 to
a871e14
Compare
|
@swift-ci please test |
compnerd
reviewed
May 19, 2022
...untime/distributed_actor_cross_module_final_class_adhoc_requirement_not_optimized_away.swift
Show resolved
Hide resolved
bnbarham
force-pushed
the
make-features-consistent
branch
from
a871e14 to
86162b9
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
make-features-consistent
branch
from
86162b9 to
f2938c4
Compare
|
@swift-ci please test |
|
@shahmishal I had a look at the counts: Edit: Going to separate re-enabling to a different PR to avoid confusion in this one. |
bnbarham
force-pushed
the
make-features-consistent
branch
from
f2938c4 to
04becae
Compare
|
@swift-ci please test Windows platform |
lit.py currently allows any substring of `target_triple` to be used as a feature in REQUIRES/UNSUPPORTED/XFAIL. This results in various forms of the OS spread across the tests and is also somewhat confusing since they aren't actually listed in the available features. Modify all OS-related features to use the `OS=` version that Swift adds instead. We can later remove `config.target_triple` so that these don't the non-OS versions don't work in the first place.
bnbarham
force-pushed
the
make-features-consistent
branch
from
04becae to
05d33a4
Compare
|
@swift-ci please test Windows platform |
bnbarham
force-pushed
the
make-features-consistent
branch
from
a5d4df9 to
c163e0f
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
|
As far as I can tell all the counts are the same. Happy for me to merge @shahmishal @compnerd? |
|
Sure, if its no-op on the counts, lets merge it and clean up subsequently. |
compnerd
approved these changes
May 25, 2022
finagolfin
added a commit
to finagolfin/swift
that referenced
this pull request
Jun 6, 2022
- swiftlang#58975 switched many tests from XFAIL on linux to linux-gnu, so seven fail on the Android CI. They are now explicitly excluded. - swiftlang#42478 removed the @NoEscape attribute for the non-Android SIL/clang-function-types tests, so I remove it for Android too. - My pull swiftlang#40779 moved the Swift pointer tags to the second byte, so SILOptimizer/concat_string_literals.64 will need to be updated for that, disabled it for now. - Compiler-rt moved the directory in which it places those libraries for Android, llvm/llvm-project@a68ccba, so lit.cfg is updated for that.
finagolfin
added a commit
to finagolfin/swift
that referenced
this pull request
Jun 7, 2022
- swiftlang#58975 switched many tests from XFAIL on linux to linux-gnu, so seven fail on the Android CI. They are now explicitly excluded. - swiftlang#42478 removed the @NoEscape attribute for the non-Android SIL/clang-function-types tests, so I remove it for Android too. - My pull swiftlang#40779 moved the Swift pointer tags to the second byte, so SILOptimizer/concat_string_literals.64 will need to be updated for that, disabled it for now. - Compiler-rt moved the directory in which it places those libraries for Android, llvm/llvm-project@a68ccba, so lit.cfg is updated for that.
finagolfin
added a commit
to finagolfin/swift
that referenced
this pull request
Jun 9, 2022
- swiftlang#58975 switched many tests from XFAIL on linux to linux-gnu, so seven fail on the Android CI and two natively. They are now explicitly excluded. - swiftlang#39605 added several C++ Interop tests, 11 of which fail on the Android CI, so disable them for now. - swiftlang#42478 removed the @NoEscape attribute for the non-Android SIL/clang-function-types tests, so I remove it for Android too. - My pull swiftlang#40779 moved the Swift pointer tags to the second byte, so SILOptimizer/concat_string_literals.64 will need to be updated for that, disabled it for now. - Compiler-rt moved the directory in which it places those libraries for Android, llvm/llvm-project@a68ccba, so lit.cfg is updated for that.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lit.py currently allows any substring of
target_tripleto be used as afeature in REQUIRES/UNSUPPORTED/XFAIL. This results in various forms of
the OS spread across the tests and is also somewhat confusing since they
aren't actually listed in the available features.
Modify all OS-related features to use the
OS=version that Swift addsinstead. We can later remove
config.target_tripleso that these don'tthe non-OS versions don't work in the first place.