tests: Add a missing typealias test case and verifications for a few FIXMEs
#60972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slavapestov ping |
slavapestov
reviewed
Sep 22, 2022
| // This occurs because the constraint solver does the wrong thing with an | ||
| // UnresolvedSpecializeExpr applied to a generic typealias. | ||
| // | ||
| // In the other cases, we manage to fold the UnresolvedSpecializeExpr in the | ||
| // precheckExpression() phase, which handles generic typealiases correctly. | ||
|
|
||
| let _ = GenericClass.TA<Float>(a: 4.0, b: 1) // FIXME |
There was a problem hiding this comment.
I think these might still be wrong? Can you verify that it produces the correct underlying type vs when the alias appears in type context?
There was a problem hiding this comment.
Oh, good catch, you’re right! What an odd bug though; I will bring back the FIXMEs and add a verification of this error.
struct S<X, Y> {
var x: X, y: Y
}
class C<T> {
typealias TA<U> = S<T, U>
}
let s1 = C.TA<Float>(x: 4.0, y: 1)
let s2: S<Double, Float> = s1 // cannot assign value of type 'S<Float, Int>' to type 'S<Double, Float>'There was a problem hiding this comment.
I believe the bug is because SpecializeExpr doesn't handle type alias types correctly. It just desugars the underlying type.
AnthonyLatsis
force-pushed
the
typealias-test
branch
from
e3f1ec6 to
7690f31
Compare
AnthonyLatsis
changed the title
typealias test case and remove a few stale FIXMEs thereintypealias test case and verifications for a few FIXMEs therein
AnthonyLatsis
changed the title
typealias test case and verifications for a few FIXMEs thereintypealias test case and verifications for a few FIXMEs
AnthonyLatsis
force-pushed
the
typealias-test
branch
from
7690f31 to
5d61a5d
Compare
AnthonyLatsis
changed the title
typealias test case and verifications for a few FIXMEstypealias test case and verifications for a few FIXMEs
|
@slavapestov ping |
slavapestov
approved these changes
Oct 10, 2022
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.