Skip to content

Tests: Add REQUIRES: CPU=x86_64 in a few Interop tests #61801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Oct 29, 2022

These tests fail when run locally on Apple Silicon Macs because they specify -target x86_64-apple-macosx10.9 instead of -target %target-cpu-apple-macosx10.9. Tests that have architecture specific output should require that architecture.

These tests fail when run locally on Apple Silicon Macs because they specify `-target x86_64-apple-macosx10.9` instead of `%target-cpu-apple-macosx10.9`. Tests that have architecture specific output should require that architecture.
@tshortli
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@tshortli tshortli merged commit 937d771 into swiftlang:main Oct 30, 2022
@tshortli tshortli deleted the disable-interop-irgen-tests-on-apple-silicon branch October 30, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants