Skip to content

Sema: Avoid emitting fixit to prefix import with @preconcurrency in swiftinterfaces #63817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tshortli
Copy link
Contributor

Remarks like the following were being emitted when compiling modules from their interfaces:

remark: add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'Preconcurrency'

This is a nuisance for clients of the module since they cannot influence whether this diagnostic is emitted.

Resolves rdar://105711934

@tshortli tshortli requested a review from DougGregor February 22, 2023 00:52
@tshortli tshortli force-pushed the suppress-add-preconcurrency-remark-in-swiftinterfaces branch from 135e7b3 to e271d75 Compare February 22, 2023 17:26
@xedin xedin removed their request for review February 22, 2023 19:47
@tshortli
Copy link
Contributor Author

swiftlang/swift-integration-tests#110

@swift-ci please smoke test and merge

… swiftinterfaces.

Resolves rdar://105711934
@tshortli tshortli force-pushed the suppress-add-preconcurrency-remark-in-swiftinterfaces branch from e271d75 to a65d2ea Compare February 22, 2023 20:53
@tshortli
Copy link
Contributor Author

@swift-ci please smoke test and merge

@tshortli
Copy link
Contributor Author

@swift-ci please smoke test macOS

@tshortli tshortli merged commit 184b514 into swiftlang:main Feb 23, 2023
@tshortli tshortli deleted the suppress-add-preconcurrency-remark-in-swiftinterfaces branch February 23, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants