Build private swift interface files from stdlib #64587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have various pieces of SPI that are getting used in tests that are failing occasionally. The swiftmodule file has the SPI, so if the compiler loads from the swiftmodule file, everything works fine. If the compiler loads the interface from the swiftinterface file, it fails to find the `startOnMainActor` declaration.
|
@swift-ci please test |
xymus
approved these changes
Mar 29, 2023
|
@swift-ci Please Build Toolchain macOS Platform |
|
Toolchain failure: |
edymtt
pushed a commit
to edymtt/swift
that referenced
this pull request
May 17, 2023
We have various pieces of SPI that are getting used in tests that are failing occasionally. The swiftmodule file has the SPI, so if the compiler loads from the swiftmodule file, everything works fine. If the compiler loads the interface from the swiftinterface file, it fails to find the `startOnMainActor` declaration. Addresses rdar://108900952 (cherry picked from commit 14956ef, swiftlang#64587)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have various pieces of SPI that are getting used in tests that are failing occasionally (at least for me). The swiftmodule file has the SPI, so if the compiler loads from the swiftmodule file, everything works fine. If the compiler loads the interface from the swiftinterface file, it fails to find the
startOnMainActordeclaration.It looks like we produce
.private.swiftinterfacefor swiftsytanx and I don't see-emit-private-swift-interface-pathin any of the Swift-Syntax cmake files, so maybe I'm doing this wrong?