Skip to content

[interop][SwiftToCxx] remove extraneous semicolon when emitting 'prag… #65662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2023
Merged

[interop][SwiftToCxx] remove extraneous semicolon when emitting 'prag… #65662

merged 1 commit into from
May 5, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented May 4, 2023

…ma clang module import'

The semicolon actually causes a compiler error in that case

@hyp hyp added the c++ interop Feature: Interoperability with C++ label May 4, 2023
@hyp hyp requested a review from ravikandhadai May 4, 2023 17:37
@hyp hyp requested review from zoecarver and egorzhdan as code owners May 4, 2023 17:37
@hyp
Copy link
Contributor Author

hyp commented May 4, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented May 4, 2023

@swift-ci please test source compatibility

@hyp
[interop][SwiftToCxx] remove extraneous semicolon when emitting 'prag…
228078f 
…ma clang module import'

The semicolon actually causes a compiler error in that case
@hyp hyp force-pushed the eng/semicolonnolon branch from b93bfbe to 228078f Compare May 4, 2023 21:57
@hyp
Copy link
Contributor Author

hyp commented May 4, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented May 4, 2023

@swift-ci please test source compatibility

@hyp
Copy link
Contributor Author

hyp commented May 5, 2023

@swift-ci please test macos platform

@hyp hyp merged commit b54a5ba into swiftlang:main May 5, 2023
@hyp hyp mentioned this pull request May 8, 2023
Merged
@finagolfin finagolfin mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egorzhdan egorzhdan egorzhdan approved these changes

@ravikandhadai ravikandhadai Awaiting requested review from ravikandhadai

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyp @egorzhdan