Repository navigation
[Backtracing][Linux] Add Linux crash handler to the runtime. - #66334
Merged
Merged
Conversation
This also adds a function to demangle a symbol, and a way for the backtracing code to report warning messages to the same place as the main runtime. I'd like to rename the _swift_isThunkFunction() SPI also, but we can't do that until we've made the changes to the _Backtracing library, so we'll do that there instead. rdar://110261430
Contributor
Author
|
@swift-ci Please smoke test |
This was referenced Jun 5, 2023
This was added to a later PR, but not to this one, though we need it here. rdar://110261430
Contributor
Author
|
@swift-ci Please smoke test |
This should have been disabled until swiftlang#66338. rdar://110261430
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
If you're wondering where the tests are, I left them until the last PR (#66338) so everything was enabled and they'd actually work. |
mikeash
approved these changes
Jun 6, 2023
mikeash
left a comment
mikeash
left a comment
Contributor
There was a problem hiding this comment.
A few little comments, but LGTM.
MaxDesiatov
reviewed
Jun 6, 2023
Mike and Max made various helpful suggestions, so I've added and updated various comments and amended the code to cope with partial reads and writes. rdar://110261430
Moved the comment for `_swift_backtrace_demangle` into the header file instead of it being in the implementation. rdar://110261430
Contributor
Author
|
@swift-ci Please smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds a function to demangle a symbol, and a way for the backtracing code to report warning messages to the same place as the main runtime.
I'd like to rename the
_swift_isThunkFunction()SPI also, but we can't do that until we've made the changes to the_Backtracinglibrary, so we'll do that there instead.rdar://110261430