[5.9][Sema] InitAccessors: Don't synthesize default memberwise arg for ini… #66464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t accessor initializations Default arguments for `init accessors` are not fully supported at the moment, so we shouldn't attempt to synthesize them in Sema just to crash during linking. (cherry picked from commit 8c54d3d)
hborla
approved these changes
Jun 8, 2023
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t accessor initializations
Cherry-pick of #66463
Default arguments for
init accessorsare not fully supported at the moment,so we shouldn't attempt to synthesize them in Sema just to crash during linking.
Scope: memberwise initializers with init accessor properties.
Main Branch PR: [Sema] InitAccessors: Don't synthesize default memberwise arg for ini… #66463
Risk: Very Low (guarded by experimental feature flag)
Reviewed By: @hborla
Testing: Only manual testing until FIXME is resolved.
(cherry picked from commit 8c54d3d)