Two optimization improvements related to access instructions #66592
Conversation
|
@swift-ci test |
|
@swift-ci benchmark |
| if (auto *ba = dyn_cast<BeginAccessInst>(memoryAddress)) { | ||
| if (ba->getEnforcement() == SILAccessEnforcement::Dynamic) { | ||
| ba->setEnforcement(SILAccessEnforcement::Static); | ||
| if (ba->getAccessKind() == SILAccessKind::Modify) |
There was a problem hiding this comment.
@eeckstein I think you might be able to take this even a step further and change SILGen to always emit these as inits, unknown. It would then be an error if access control Can not convert it to static. I did something like this for consuming parameters which use deinit. Anyways, just a friendly thought.
There was a problem hiding this comment.
I thought about this, too. But SILGen doesn't know yet if it's an init or re-assign. And e.g. in a class initializer you can let self escape (after all members are initialized) and then re-assign a member. I'm not sure if it's even safe to guard such a reassign-after-self-escape as a statically checked access.
| if (auto *ba = dyn_cast<BeginAccessInst>(memoryAddress)) { | ||
| if (ba->getEnforcement() == SILAccessEnforcement::Dynamic) { | ||
| ba->setEnforcement(SILAccessEnforcement::Static); | ||
| if (ba->getAccessKind() == SILAccessKind::Modify) |
…ations to a static accesses In case of `var` initializations, SILGen creates a dynamic begin/end_access pair around the initialization store. If it's an initialization (and not a re-assign) it's guanranteed that it's an exlusive access and we can convert the access to an `[init] [static]` access. swiftlang#66496
Don't let access instructions prevent eliminating dead allocations swiftlang#66496
eeckstein
force-pushed
the
access-optimizations
branch
from
0cf7cf2 to
5c5cd9f
Compare
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
In case of
varinitializations, SILGen creates a dynamic begin/end_access pair around the initialization store.If it's an initialization (and not a re-assign) it's guanranteed that it's an exlusive access and we can convert the access to an
[init] [static]access.Don't let access instructions prevent eliminating dead allocations
Resolves #66496