Skip to content

[cxx-interop] add a testcase to verify that 'borrowing' works with co… #66687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2023
Merged

[cxx-interop] add a testcase to verify that 'borrowing' works with co… #66687

merged 1 commit into from
Jul 14, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Jun 15, 2023

…pyable C++ types

This lets us verify that our suggested pattern for calling unsafe functions is working as intended in Swift

This also lets us verify that we can still pass borrowed C++ types to C++ functions that take in a const ref parameter

Tests now fixed #61454

@hyp hyp added c++ interop Feature: Interoperability with C++ ownership Feature: Ownership modifiers and semantics labels Jun 15, 2023
@hyp hyp requested review from zoecarver and egorzhdan as code owners June 15, 2023 23:49
@hyp
Copy link
Contributor Author

hyp commented Jun 15, 2023

@swift-ci please smoke test

@hyp hyp mentioned this pull request Jun 16, 2023
Merged
@hyp
Copy link
Contributor Author

hyp commented Jun 16, 2023

@swift-ci please test

1 similar comment
@hyp
Copy link
Contributor Author

hyp commented Jul 11, 2023

@swift-ci please test

@hyp hyp force-pushed the eng/cxx-borrowing branch from 2c71e80 to f0885ce Compare July 12, 2023 21:52
@hyp
Copy link
Contributor Author

hyp commented Jul 12, 2023

@swift-ci please test

@hyp hyp force-pushed the eng/cxx-borrowing branch from f0885ce to 1e2a3e5 Compare July 13, 2023 01:14
@hyp
Copy link
Contributor Author

hyp commented Jul 13, 2023

@swift-ci please test and merge

1 similar comment
@hyp
Copy link
Contributor Author

hyp commented Jul 13, 2023

@swift-ci please test and merge

@hyp hyp force-pushed the eng/cxx-borrowing branch from 1e2a3e5 to 64cdd93 Compare July 13, 2023 03:20
@hyp
Copy link
Contributor Author

hyp commented Jul 13, 2023

@swift-ci please test and merge

@hyp
[cxx-interop] add a testcase to verify that 'borrowing' works with co…
3652347 
…pyable C++ types

This lets us verify that our suggested pattern for calling unsafe functions is working as intended in Swift

This also lets us verify that we can still pass borrowed C++ types to C++ functions that take in a const ref parameter

Tests now fixed swiftlang#61454
@hyp hyp force-pushed the eng/cxx-borrowing branch from 64cdd93 to 3652347 Compare July 14, 2023 16:00
@hyp
Copy link
Contributor Author

hyp commented Jul 14, 2023

@swift-ci please test and merge

@swift-ci swift-ci merged commit b6d248f into swiftlang:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++ ownership Feature: Ownership modifiers and semantics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[interop] Tracking issue to track support for immutable noncopyable borrows for C++ types in Swift
2 participants
@hyp @swift-ci