[5.9][ConstraintSystem] Use fallback type constraint to default pack expansion #66709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please nominate |
…sion - Introduces a generalized version of `DefaultClosureType` constraint. - Binding of pack expansion types is delayed until solving but use of `Defaultable` was preventing it from being considered early because that constraint impacts binding set ranking, switching to `FallbackType` constraint give us better semantics where pack expansion type variables are going to be bound as soon as they have a contextual type. Resolves: rdar://110819621 (cherry picked from commit c0d0908) (cherry picked from commit 4823bf2)
xedin
force-pushed
the
fix-late-binding-of-pack-expansions-5.9
branch
from
d53c4ae to
fae9a2e
Compare
|
@swift-ci please test |
hborla
approved these changes
Jun 16, 2023
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #66708
Binding of pack expansion types is delayed until solving but use of
Defaultablewas preventing it from being considered early because that constraint impacts
binding set ranking, switching to
FallbackTypeconstraint give us better semanticswhere pack expansion type variables are going to be bound as soon as they have
a contextual type.
Scope: Expressions with value pack expansions used inside of closures.
Main Branch PR: [ConstraintSystem] Use fallback type constraint to default pack expansion #66708
Risk: Very Low
Reviewed By: @hborla
Testing: Added regression test-cases to the suite.
Resolves: rdar://110819621
(cherry picked from commit c0d0908) (cherry picked from commit 4823bf2)