Skip to content

[5.9] [Parse] Avoid creating binding patterns in a couple more positions #66804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2023
Merged

[5.9] [Parse] Avoid creating binding patterns in a couple more positions #66804

merged 1 commit into from
Jun 21, 2023

Conversation

hamishknight
Copy link
Contributor

5.9 cherry-pick of #66718

  • Explanation: Allows the parser to correctly parse the patterns case let E<Int>.foo(x) and case let (y[0], x), where only x becomes a binding. Previously we would attempt to treat E and y as bindings.
  • Scope: Affects parsing of patterns
  • Issue: rdar://108738034
  • Risk: Low, only affects code that was previously invalid
  • Testing: Added tests to test suite
  • Reviewer: Alex Hoppen

@hamishknight
[Parse] Avoid creating binding patterns in a couple more positions
a6246f2 
If we have an identifier followed by either `[` or
a generic argument list, avoid turning it into a
binding pattern, as that would be invalid. This
is similar to the existing rule we have where a
following `(` prevents a binding pattern from
being formed.

This allows patterns such as `let E<Int>.foo(x)` and
`let (y[0], x)` to compile, where `x` is treated
as a binding, but no other identifier is.

rdar://108738034
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.9 labels Jun 21, 2023
@hamishknight hamishknight requested a review from a team as a code owner June 21, 2023 11:29
@hamishknight hamishknight mentioned this pull request Jun 21, 2023
Merged
@hamishknight
Copy link
Contributor Author

swiftlang/swift-syntax#1826

@swift-ci please test

@hamishknight hamishknight merged commit f4dbf0f into swiftlang:release/5.9 Jun 21, 2023
@hamishknight hamishknight deleted the getting-out-of-a-bind-5.9 branch June 21, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishknight @DougGregor