[5.9] StackPromotion: fix a crash due to a problem in liferange evaluation #67391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The analysis to check if an alloc_ref outlives it's "inner" liferange had a bug which resulted in a crash in the StackPromotion pass rdar://112275272
|
@swift-ci test |
|
We're getting close to 5.9 and I don't think this is critical enough. Let's hold for later. |
tbkka
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The analysis to check if an alloc_ref outlives its "inner" liferange had a bug which resulted in a crash in the StackPromotion pass. It is very rare that this bug shows up and I only found it by coincidence. Still, it makes sense to fix it in 5.9 because the risk is very low.
Issue: rdar://112275272
Risk: Very low. It's a small change which makes the optimization more conservative.
Testing: With a regression test
Reviewer: @atrick
Main branch PR: StackPromotion: fix a crash due to a problem in liferange evaluation #67331