Skip to content

[Linux] Fix installation of swift-backtrace binary #67507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

al45tair
Copy link
Contributor

We weren't installing the swift-backtrace binary on Linux because (a) we weren't installing the libexec component, and (b) there was a bug in the CMake scripts that made it not work anyway.

al45tair added 2 commits July 25, 2023 15:23
We weren't installing the libexec component for Linux.

rdar://112662487
The script erroneously used `UNIVERSAL_LIBRARY_NAME` instead of
`UNIVERSAL_NAME`.

rdar://112662487
@al45tair al45tair requested a review from a team as a code owner July 25, 2023 14:25
@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair
Copy link
Contributor Author

Explanation: We needed to add libexec to the list of components to install on Linux (which is in the build preset). Additionally, a mis-spelled variable name in the CMake scripts meant that we still wouldn't have installed anything, even after that.
Risk: Low. Only affects Linux (the swift-backtrace program isn't installed on Windows, and it's installed in a different manner on macOS).
Original PR: #67483 #67505
Reviewed by: @ktoso @mikeash @tomerd
Resolves: rdar://112662487
Tests: There aren't any explicit tests for the install step. We will be checking the Docker images to make sure that the backtracer is installed there (we already need to modify the "slim" images, I think, to include it).

@al45tair al45tair added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.9 labels Jul 25, 2023
@al45tair al45tair merged commit ae661de into swiftlang:release/5.9 Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants