Skip to content

[cxx-interop][linux] modularize the bits part of libstdc++ #67557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2023
Merged

[cxx-interop][linux] modularize the bits part of libstdc++ #67557

merged 1 commit into from
Jul 28, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Jul 27, 2023

Fixes #64457

@hyp hyp added the c++ interop Feature: Interoperability with C++ label Jul 27, 2023
@hyp hyp requested review from zoecarver and egorzhdan as code owners July 27, 2023 01:09
@hyp
Copy link
Contributor Author

hyp commented Jul 27, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Jul 27, 2023

@swift-ci please test source compatibility

@hyp
Copy link
Contributor Author

hyp commented Jul 27, 2023

@swift-ci please smoke test linux

1 similar comment
@hyp
Copy link
Contributor Author

hyp commented Jul 27, 2023

@swift-ci please smoke test linux

@hyp
Copy link
Contributor Author

hyp commented Jul 27, 2023

@swift-ci please smoke test

egorzhdan
egorzhdan approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also think it's fine to include the bits headers into the top-level std module if that's easier, since the bits submodule is going to get pulled in as a dependency of the top level module anyway.

@hyp
Copy link
Contributor Author

hyp commented Jul 27, 2023

@swift-ci please smoke test

@hyp
Copy link
Contributor Author

hyp commented Jul 27, 2023

LGTM. I also think it's fine to include the bits headers into the top-level std module if that's easier, since the bits submodule is going to get pulled in as a dependency of the top level module anyway.

Yeah true, it might be better to make it a non-submodule.

@hyp
Copy link
Contributor Author

hyp commented Jul 27, 2023

@swift-ci please smoke test

@hyp
Copy link
Contributor Author

hyp commented Jul 27, 2023

@swift-ci please smoke test

@hyp
Copy link
Contributor Author

hyp commented Jul 27, 2023

@swift-ci please smoke test linux

1 similar comment
@hyp
Copy link
Contributor Author

hyp commented Jul 27, 2023

@swift-ci please smoke test linux

@hyp hyp merged commit a219cfa into swiftlang:main Jul 28, 2023
@hyp hyp mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egorzhdan egorzhdan egorzhdan approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swift cannot use -enable-experimental-cxx-interop on Linux with Foundation
2 participants
@hyp @egorzhdan