Narrow @_originallyDefinedIn check in NominalTypeDecl::isResilient to protocols.
#67979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to protocols. And add a comment explaining why this check is only relevant to protocols, and shouldn't be copied to other similar-looking isResilient methods on other types. According to 2537602, which introduced the original `@_originallyDefinedIn` check, this check was necessary to maintain ABI compatibility when protocol declarations are moved, but in all other cases, we should treat declarations as resilient when they are defined in other library-evolution-enabled modules, even when the declaration was originally defined in the current module.
|
@swift-ci Please test |
tshortli
approved these changes
Aug 17, 2023
|
Thank you for narrowing the check and the detailed comments, Joe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add a comment explaining why this check is only relevant to protocols, and shouldn't be copied to other similar-looking isResilient methods on other types. According to 2537602, which introduced the original
@_originallyDefinedIncheck, this check was necessary to maintain ABI compatibility when protocol declarations are moved, but in all other cases, we should treat declarations as resilient when they are defined in other library-evolution-enabled modules, even when the declaration was originally defined in the current module.