Disable destructuring initializations in struct let stored properties.
#68930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test source compatibility |
jckarter
force-pushed
the
disable-let-stored-property-destructuring
branch
from
5d278a1 to
709beb1
Compare
|
@swift-ci Please test source compatibility |
jckarter
force-pushed
the
disable-let-stored-property-destructuring
branch
from
709beb1 to
1425473
Compare
|
@swift-ci Please test source compatibility |
jckarter
force-pushed
the
disable-let-stored-property-destructuring
branch
from
1425473 to
7c755ea
Compare
This looks like it was never properly implemented, since when we generate the memberwise initializer for the struct in SILGen, it incorrectly tries to apply the entire initializer expression to each variable binding in the pattern, rather than destructuring the result and pattern-matching it to the variables. Since it never worked it doesn't look like anyone is using this, so let's put up an error saying it's unsupported until we can implement it properly. Add `StructLetDestructuring` as an experimental feature flag so that tests around the feature for things like module interface printing can still work.
jckarter
force-pushed
the
disable-let-stored-property-destructuring
branch
from
7c755ea to
b4f5369
Compare
|
@swift-ci Please test |
jckarter
changed the title
let stored properties.
jckarter
requested review from
hborla,
slavapestov,
xedin and
tshortli
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like it was never properly implemented, since when we generate the memberwise initializer for the struct in SILGen, it incorrectly tries to apply the entire initializer expression to each variable binding in the pattern, rather than destructuring the result and pattern-matching it to the variables. Since it never worked it doesn't look like anyone is using this, so let's put up an error saying it's unsupported until we can implement it properly. Add
StructLetDestructuringas an experimental feature flag so that tests around the feature for things like module interface printing can still work.Fixes #68915 | rdar://116343732.