[Sema] Move predates concurrency remarks to warnings #69417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remarks are intended to be enabled via eg. `-R...`, where as `(add|remove)_predates_concurrency_import` is a diagnostic that's always output without any `-R` flag. Move it to a warning instead. Resolves rdar://114207080.
bnbarham
requested review from
ktoso,
kavon,
hborla,
slavapestov and
xedin
as code owners
bnbarham
commented
Oct 25, 2023
| @@ -1,15 +0,0 @@ | |||
| // RUN: %empty-directory(%t) | |||
There was a problem hiding this comment.
I'm unsure what we actually want to do here. There's not really any other remark that would make sense to check here, but then that makes me wonder if -suppress-remarks makes sense as an option anyway.
|
@swift-ci please test |
artemcm
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remarks are intended to be enabled via eg.
-R..., where as(add|remove)_predates_concurrency_importis a diagnostic that's always output without any-Rflag. Move it to a warning instead.Resolves rdar://114207080.