[AutoDiff] Fix custom derivative thunk for Optional #71721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Tagging @BradLarson @rxwei |
rxwei
approved these changes
Feb 19, 2024
|
@swift-ci please test |
asl
force-pushed
the
optional-nil-coalescing
branch
from
6f14cf2 to
e763422
Compare
|
@swift-ci please test |
The patch fixes the issue swiftlang#55882 and enables the nil coalescing operator (aka `??`) for Optional type.
empty JVPs / VJPs has the same linkage as the original function sans external flag and also inherit serialization flag. This works for all cases but not for hidden_external ones. Drop serializable flag for such case
asl
force-pushed
the
optional-nil-coalescing
branch
from
e763422 to
c653a7d
Compare
|
@swift-ci please test |
MaxDesiatov
added a commit
that referenced
this pull request
Jun 10, 2024
This reverts commit aa5dddb.
MaxDesiatov
added a commit
that referenced
this pull request
Jun 10, 2024
This reverts commit aa5dddb.
MaxDesiatov
added a commit
that referenced
this pull request
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch fixes the issue #55882 and enables the nil coalescing operator (aka
??) for Optional type.