Skip to content

[Diagnostics] Clarify the wording of error_in_future_swift_version. #72002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

hborla
Copy link
Member

@hborla hborla commented Mar 1, 2024

Folks are confused about language mode versus compiler version, and this warning does not specify which one it is talking about. Clarify that the warning will become an error in the next major language version, not the tools version. Also, add an educational note explaining tools version versus language mode version.

@hborla
Copy link
Member Author

hborla commented Mar 1, 2024

@swift-ci please smoke test

@hborla hborla force-pushed the adjust-language-mode-warning branch from 2d63307 to 6b9d70b Compare March 1, 2024 05:34
@hborla
Copy link
Member Author

hborla commented Mar 1, 2024

@swift-ci please smoke test

@hborla
Copy link
Member Author

hborla commented Mar 1, 2024

@swift-ci please test Windows

@hborla hborla force-pushed the adjust-language-mode-warning branch from 6b9d70b to 466a021 Compare March 1, 2024 20:05
@hborla
Copy link
Member Author

hborla commented Mar 1, 2024

@swift-ci please smoke test

@ahoppen ahoppen removed their request for review March 1, 2024 20:07
@hborla hborla merged commit d83d046 into swiftlang:main Mar 1, 2024
@hborla hborla deleted the adjust-language-mode-warning branch March 1, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants