-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[IRGen] Outlined consume functions call noncopyable deinits. #72034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nate-chandler
merged 18 commits into
swiftlang:main
from
nate-chandler:rdar123560548-onone
Mar 2, 2024
Merged
[IRGen] Outlined consume functions call noncopyable deinits. #72034
nate-chandler
merged 18 commits into
swiftlang:main
from
nate-chandler:rdar123560548-onone
Mar 2, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In debug builds, provide some context when an archetype fails to be found.
In preparation for them handling more polymorphic arguments than merely metadata.
Gather the circumstances under which the collector should be used and what it should collect separately and then collect only in one place if collection should happen.
Not all metadata that the OutliningMetdataCollector collects is for layout anymore.
If any deinit must be called, just pass the full generic environment of the type being destroyed.
The include the necessary metadata.
They include the necessary metadata.
d77b34b
to
f638918
Compare
@swift-ci please test |
@swift-ci please smoke test macos platform |
It looks like failing on 32bit platforms https://ci.swift.org/job/oss-swift-pr-test-crosscompile-wasm-ubuntu-20_04/84/
|
Thanks, @kateinoigakukun . Fixed here: #72051 . |
Thanks a lot! @nate-chandler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any deinits will be called, pass the full generic environment of the type for which an outlined value function is being emitted. Use the metadata collector to determine whether such deinits exist for single and multi payload enum consumes.