[region-isolation] Take into account that Swift's RPO order doesn't include blocks that are dead. #72077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nclude blocks that are dead. When we run RegionAnalysis, since it uses RPO order, we do not visit dead blocks. This can create a problem when we emit diagnostics since we may merge in a value into the region that was never actually defined. In this patch, if we actually visit the block while performing dataflow, I mark a bit in its state saying that it was live. Then when we emit diagnostics, I do not visit blocks that were not marked live. rdar://124042351
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run RegionAnalysis, since it uses RPO order, we do not visit dead blocks. This can create a problem when we emit diagnostics since we may merge in a value into the region that was never actually defined. In this patch, if we actually visit the block while performing dataflow, I mark a bit in its state saying that it was live. Then when we emit diagnostics, I do not visit blocks that were not marked live.
rdar://124042351