[6.0][SIL] Adjust isTypeMetadataForLayoutAccessible() to visit more lowered positions
#72638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… positions Fixes part of swiftlang#67645, rdar://119267393
simanerush
added
🍒 release cherry pick
|
@swift-ci please test |
1 task
|
Can you please fill out the template from https://forums.swift.org/t/swift-6-0-release-process/70220#pull-requests-for-release-branch-8 in the PR description? Thank you! |
|
@hborla Done! |
hborla
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #71376
isTypeMetadataForLayoutAccessible()in SIL did not visit lowered positions for pack expansion types, resulting in compiler crashes.Assertion failed: (type->isLegalFormalType())when declaring a tuple from a parameter pack expansion #71455, Crash at compilation when calling variadic generic function using pack expansion as argument #67645, rdar://119267393isTypeMetadataForLayoutAccessible()to visit more lowered positions #71376