Skip to content

Complete update-checkout stash test #72823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fabricerenard12
Copy link

@fabricerenard12 fabricerenard12 commented Apr 3, 2024

Resolves #72523

Test coverage for #71178 .

@fabricerenard12 fabricerenard12 marked this pull request as draft April 3, 2024 22:55
@fabricerenard12 fabricerenard12 marked this pull request as ready for review April 3, 2024 22:59
@AnthonyLatsis AnthonyLatsis self-requested a review April 18, 2024 14:26
@hnrklssn
Copy link
Contributor

hnrklssn commented Mar 6, 2025

@AnthonyLatsis @fabricerenard12 Is this still up-to-date? I think it'd good if we got some more test coverage for update-checkout. From my brief overview this looks like it does what the linked issue asks for, so I'm inclined to approve it unless someone else has any comments.

@hnrklssn
Copy link
Contributor

hnrklssn commented Mar 6, 2025

@swift-ci please smoke test

Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also verify that the file actually pops up again after invoking git stash pop?

#
# This source file is part of the Swift.org open source project
#
# Copyright (c) 2024 Apple Inc. and the Swift project authors
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024 → 2025

@AnthonyLatsis AnthonyLatsis requested a review from edymtt March 6, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test coverage for update-checkout --stash option
3 participants