Skip to content

[6.0] [Index] Avoid forming relations to non-indexed decls #72950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

hamishknight
Copy link
Contributor

6.0 cherry-pick of #72930

  • Explanation: Avoid reporting relations to decls that are not indexed.
  • Scope: Affects indexing data produced by the compiler.
  • Issue: rdar://126137541
  • Risk: Low, the fix is fairly straigtforward
  • Testing: Added tests to test suite
  • Reviewer: Ben Barham

Check to see whether we can index the given decl
before reporting it as a container, walking up to
a parent if we need to. This also lets us simplify
the AnyPattern handling a bit.

rdar://126137541
If we shouldn't index the related decl, don't record
it as a relation.
@hamishknight hamishknight requested a review from bnbarham April 10, 2024 11:07
@hamishknight hamishknight requested a review from a team as a code owner April 10, 2024 11:07
@hamishknight hamishknight added swift 6.0 🍒 release cherry pick Flag: Release branch cherry picks labels Apr 10, 2024
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight merged commit e518306 into swiftlang:release/6.0 Apr 10, 2024
5 checks passed
@hamishknight hamishknight deleted the containment-6.0 branch April 10, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants