Skip to content

[6.0][stdlib] ManagedBuffer: Fix misapplied linkage names for legacy entry points #73401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented May 2, 2024

… points

I accidentally copy and pasted the mangled symbol names in the wrong order, so existing callers got directed to the wrong entry points, and things got terribly, terribly wrong.

(We badly need a sensible replacement for these `@_silgen_name` hacks.)

Huge thanks to @edymtt for spotting this!

rdar://127016847
(cherry picked from commit 3061531)
@lorentey lorentey requested a review from a team as a code owner May 2, 2024 22:06
@lorentey
Copy link
Member Author

lorentey commented May 2, 2024

@swift-ci test

@lorentey lorentey merged commit 1420ee7 into swiftlang:release/6.0 May 4, 2024
5 checks passed
@lorentey lorentey deleted the fix-managedbuffer-abi-mixup-6.0 branch May 4, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants