Skip to content

[6.0🍒] Demangler: edge case in existential demangling #74437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2024
Merged

[6.0🍒] Demangler: edge case in existential demangling #74437

merged 2 commits into from
Jun 17, 2024

Conversation

kavon
Copy link
Member

@kavon kavon commented Jun 14, 2024 •
edited
Loading

  • Explanation: Fixes demangling of noncopyable existentials.
  • Scope: Important for supporting noncopyable existentials.
  • Issue: rdar://128695929
  • Original PR: Demangler: edge case in existential demangling #74436
  • Risk: Low, it only expands the cases that the demangler handles.
  • Testing: Testing included.
  • Reviewer: TBD

@kavon
Demangler: edge case in existential demangling
4cd8313 
We now may have constrained existentials that have no primary associated
types, so there won't be any arguments for the parameterized protocol
type. Because the "constrained" part is that there's an inverse.

resolves rdar://128695929

(cherry picked from commit b604488)
@kavon kavon requested a review from a team as a code owner June 14, 2024 19:54
@kavon
Copy link
Member Author

kavon commented Jun 14, 2024

@swift-ci test

@kavon
Copy link
Member Author

kavon commented Jun 15, 2024

@swift-ci test

@kavon kavon enabled auto-merge June 15, 2024 00:45
@kavon kavon requested review from slavapestov and jckarter June 15, 2024 00:45
@kavon kavon merged commit f2c13a6 into swiftlang:release/6.0 Jun 17, 2024
5 checks passed
@kavon kavon deleted the 6.0-demangling-rdar128695929 branch June 25, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckarter jckarter jckarter approved these changes

@tbkka tbkka tbkka approved these changes

@slavapestov slavapestov Awaiting requested review from slavapestov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kavon @jckarter @tbkka