Change the generated code model to Large on Windows 64 bit #7489
Conversation
|
@swift-ci please smoke test |
lib/IRGen/IRGen.cpp
Outdated
| // On Windows 64 bit, dlls are loaded above the max address for 32 bits. | ||
| // This means that a default CodeModel causes generate code to segfault | ||
| // when run. | ||
| if (Triple.isArch64Bit() && Triple.isOSWindows()) |
There was a problem hiding this comment.
Should Cygwin-32 continue using the large model too?
There was a problem hiding this comment.
It's unclear, I'm taking this from a comment in that Pr:
Cygwin should use large memory model as default.(This may be changed
if someone ports to 32bit)
I think for now specialising this to 64 bit, which is the only one that's been tested, is the right way to go.
Logically speaking, I'm not sure how referencing a 32 bit address on a 32 bit architecture would be bad, but I can't test this
There was a problem hiding this comment.
@tinysun212, any insights to offer?
There was a problem hiding this comment.
@compnerd if no insights are to be offered
|
@swift-ci please smoke test |
|
It seems that nobody ports to 32bit Cygwin. |
|
LGTM |
See discussion in #3841
Before this, generated code referenced 32 bit addresses, causing segfaults when running it on Windows 64 bit.