[overlay] Support the older @rpath Darwin library for _Builtin_float's $ld$previous$ symbols #74920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-twilightcoder
requested review from
hyp,
DougGregor,
lorentey,
ktoso and
a team
and removed request for
a team and
ktoso
ian-twilightcoder
force-pushed
the
builtin_float_module-abi-name
branch
6 times, most recently
from
6b8c83a to
63f11c8
Compare
DougGregor
reviewed
Jul 8, 2024
stdlib/public/Concurrency/linker-support/magic-symbols-for-install-name.c
Outdated
Show resolved
Hide resolved
stdlib/public/Concurrency/linker-support/magic-symbols-for-install-name.c
Outdated
Show resolved
Hide resolved
ian-twilightcoder
force-pushed
the
builtin_float_module-abi-name
branch
from
63f11c8 to
fba34f8
Compare
…s $ld$previous$ symbols The _Builtin_float symbols were moved twice, most recently from the OS Darwin library, but previously they were in the embedded @rpath Darwin library. @_originallyDefinedIn doesn't support multiple install names, but it can be replaced with -module-abi-name, and then multiple $ld$previous$ symbols can be used. Update the Platform and Concurrency magic symbols to use $ld$previous$ everywhere. rdar://130107191
ian-twilightcoder
force-pushed
the
builtin_float_module-abi-name
branch
from
fba34f8 to
9e9d66e
Compare
|
@swift-ci smoke test |
mikeash
approved these changes
Jul 9, 2024
ian-twilightcoder
added a commit
to ian-twilightcoder/swift
that referenced
this pull request
Sep 11, 2024
…ailing on macCatalyst When I did swiftlang#74920 I forgot to update test/Concurrency/Backdeploy/linking_maccatalyst.swift the same way linking.swift got updated.
ian-twilightcoder
added a commit
to ian-twilightcoder/swift
that referenced
this pull request
Sep 11, 2024
…ailing on macCatalyst When I did swiftlang#74920 I forgot to update test/Concurrency/Backdeploy/linking_maccatalyst.swift the same way linking.swift got updated.
ian-twilightcoder
added a commit
to ian-twilightcoder/swift
that referenced
this pull request
Sep 11, 2024
…ailing on macCatalyst When I did swiftlang#74920 I forgot to update test/Concurrency/Backdeploy/linking_maccatalyst.swift the same way linking.swift got updated. rdar://132710925
ian-twilightcoder
added a commit
to ian-twilightcoder/swift
that referenced
this pull request
Nov 9, 2024
…t is failing on macCatalyst When I did swiftlang#74920 I forgot to update test/Concurrency/Backdeploy/linking_maccatalyst.swift the same way linking.swift got updated. rdar://132710925
ian-twilightcoder
added a commit
to ian-twilightcoder/swift
that referenced
this pull request
Nov 9, 2024
…ift is failing on macCatalyst When I did swiftlang#74920 I forgot to update test/Concurrency/Backdeploy/linking_maccatalyst.swift the same way linking.swift got updated. rdar://132710925
ian-twilightcoder
added a commit
to ian-twilightcoder/swift
that referenced
this pull request
Nov 9, 2024
…ift is failing on macCatalyst When I did swiftlang#74920 I forgot to update test/Concurrency/Backdeploy/linking_maccatalyst.swift the same way linking.swift got updated. rdar://132710925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _Builtin_float symbols were moved twice, most recently from the OS Darwin library, but previously they were in the embedded @rpath Darwin library. @_originallyDefinedIn doesn't support multiple install names, but it can be replaced with -module-abi-name, and then multiple $ld$previous$ symbols can be used. Update the Platform and Concurrency magic symbols to use $ld$previous$ everywhere.
rdar://130107191