Skip to content

[6.0] [Index] Record relations for pseudo accessors #75249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

hamishknight
Copy link
Contributor

6.0 cherry-pick of #75241

  • Explanation: Fixes a regression where we would no longer report any relations for pseudo accessors
  • Scope: Affects the indexing of relations for pseudo accessors
  • Issue: rdar://131749546
  • Risk: Low, the fix is straightforward and limited in scope
  • Testing: Added tests to test suite
  • Reviewer: Ben Barham

I recently accidentally broke this, make sure
we carve out an exception for pseudo accessors in
`shouldIndex` such that we record e.g override
relations for them.

rdar://131749546
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.0 labels Jul 15, 2024
@hamishknight hamishknight requested a review from bnbarham July 15, 2024 18:33
@hamishknight hamishknight requested a review from a team as a code owner July 15, 2024 18:33
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight enabled auto-merge July 15, 2024 21:52
@hamishknight hamishknight merged commit 7765fd6 into swiftlang:release/6.0 Jul 16, 2024
5 checks passed
@hamishknight hamishknight deleted the sudo-override-6.0 branch July 16, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants