Skip to content

Reflection tests are incompatible with ASAN #75509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

tbkka
Copy link
Contributor

@tbkka tbkka commented Jul 26, 2024

#75415 sped up Reflection tests by having the test harness make broader requests for blocks of memory. This upset ASAN since those requests are (by design) not aligned with heap allocations. #75454 attempted to work around this but failed, so let's just disable all of the relevant tests whenever ASAN is enabled.

@tbkka tbkka requested review from slavapestov and ktoso as code owners July 26, 2024 16:56
@tbkka
Copy link
Contributor Author

tbkka commented Jul 26, 2024

@swift-ci Please test

@tbkka tbkka enabled auto-merge July 26, 2024 16:56
@tbkka
Copy link
Contributor Author

tbkka commented Jul 26, 2024

@swift-ci Please test Linux Platform

@tbkka
Copy link
Contributor Author

tbkka commented Jul 26, 2024

@swift-ci Please test macOS Platform

@tbkka tbkka merged commit 6c9edfe into swiftlang:main Jul 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant