[build.ps1] Support llvm-lit tests with REQUIRES: native condition on Windows
#77005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lit adds the 'native' item in available_features, if the target-triple and host-triple strings are equivalent. While we hardcode LLVM_DEFAULT_TARGET_TRIPLE to x86_64-unknown-windows-msvc in the CMake cache file, LLVM_HOST_TRIPLE was inferred as x86_64-pc-windows-msvc automatically. These triples are compatible, but not string-equivalent and so lit skipped all related tests. Let's fix it and also set LLVM_HOST_TRIPLE explicitly.
|
Seems reasonable to me! |
hyp
approved these changes
Oct 15, 2024
|
Thanks for reviewing @hyp, I think this is ready t land. |
weliveindetail
changed the title
REQUIRES: native conditionREQUIRES: native condition on Windows
|
@swift-ci please test |
|
On macOS the The Windows build was skipped apparently. Maybe at some point we try again: |
weliveindetail
changed the title
REQUIRES: native condition on WindowsREQUIRES: native condition on Windows
|
Let's land this together with the overall PR for LLDB testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lit adds the
nativeitem in available_features, if the target-triple and host-triple strings are equivalent. While we hardcode LLVM_DEFAULT_TARGET_TRIPLE tox86_64-unknown-windows-msvcin the CMake cache file, LLVM_HOST_TRIPLE is inferred automatically, which results inx86_64-pc-windows-msvc.These triples are compatible, but not string-equivalent and so lit skips all related tests. Let's fix by setting LLVM_HOST_TRIPLE explicitly. We cannot do it in the cache file, because we have to consider cross-compilation.