[6.0][Concurrency] Fix preconcurrency downgrade behavior for Sendable closures and generic requirements.
#77476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures. Sendable violations inside `@preconcurrency @Sendable` closures should be suppressed in minimal checking, and diagnosed as warnings under complete checking, including the Swift 6 language mode. (cherry picked from commit d2d317a)
to warnings even in Swift 6. (cherry picked from commit a31a9d3)
…lures to warnings in Swift 6 mode. (cherry picked from commit e21bf2f)
|
@swift-ci please test |
|
erasure expressions for arguments to `@preconcurrency` functions in Swift 6 mode. (cherry picked from commit 806de5a)
|
Heh, on |
|
@swift-ci please test |
hborla
force-pushed
the
6.0-preconcurrency-downgrade
branch
from
4dbc06e to
1585f60
Compare
airspeedswift
approved these changes
Nov 11, 2024
DougGregor
approved these changes
Nov 11, 2024
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@preconcurrency @Sendableclosures, or not satisfying aSendableconformance requirement of a@preconcurrencygeneric declaration, should be suppressed in minimal checking, and diagnosed as warnings under complete checking, including the Swift 6 language mode. This change fixes an issue where warnings were still produced in minimal checking, and errors were still produced under -swift-version 6, which means that libraries cannot stage in new Sendable annotations if their clients have already migrated to Swift 6.@preconcurrencydeclarations with@Sendableannotations orwhere T: Sendablegeneric requirements.Sendabletype when using Swift 5 mode with @preconcurrency API #76652Sendableclosures and generic requirements. #77459, [Concurrency] Handle self apply exprs when computing@preconcurencyin the availability checker. #77510Sendableannotation was on a@preconcurrencydeclaration, the only effect of this change is downgrading some concurrency diagnostics.