Skip to content

WIP: [IRGen][runtime] Reduce object header to 8 bytes on 32-bit platforms. #7837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

WIP: [IRGen][runtime] Reduce object header to 8 bytes on 32-bit platforms. #7837

wants to merge 9 commits into from

Conversation

gparker42
Copy link
Contributor

No description provided.

@gparker42
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Mar 1, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 1bad41d0515659cdd3339b48739778b7a5b1d7e8
Test requested by - @gparker42

@gparker42
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Mar 2, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 1bad41d0515659cdd3339b48739778b7a5b1d7e8
Test requested by - @gparker42

@swift-ci
Copy link
Contributor

swift-ci commented Mar 2, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 1bad41d0515659cdd3339b48739778b7a5b1d7e8
Test requested by - @gparker42

@gparker42 gparker42 changed the title [IRGen][runtime] Reduce object header to 8 bytes on 32-bit platforms. WIP: [IRGen][runtime] Reduce object header to 8 bytes on 32-bit platforms. Mar 7, 2017
@gparker42 gparker42 force-pushed the GrP-PR-23107E5F-1A70-433F-8B71-23632DA0D5C2 branch from 38ff7ef to 77298e8 Compare April 5, 2017 23:19
@gparker42
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 6, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 4c2e1d6
Test requested by - @gparker42

@swift-ci
Copy link
Contributor

swift-ci commented Apr 6, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 4c2e1d6
Test requested by - @gparker42

@gparker42
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 7, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 4c2e1d6
Test requested by - @gparker42

@swift-ci
Copy link
Contributor

swift-ci commented Apr 7, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 4c2e1d6
Test requested by - @gparker42

@gparker42
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 8, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 4c2e1d6
Test requested by - @gparker42

@swift-ci
Copy link
Contributor

swift-ci commented Apr 8, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 4c2e1d6
Test requested by - @gparker42

@gparker42
Copy link
Contributor Author

@swift-ci please test

@gparker42
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 0347864
Test requested by - @gparker42

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 0347864
Test requested by - @gparker42

@gparker42
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 0347864
Test requested by - @gparker42

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 0347864
Test requested by - @gparker42

@gparker42
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 63999b9
Test requested by - @gparker42

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 63999b9
Test requested by - @gparker42

jckarter added a commit to jckarter/swift that referenced this pull request May 3, 2017
@jckarter
Support key paths on 32-bit platforms.
525001f 
I had optimistically written the code here optimistically hoping swiftlang#7837 would land in time for me to merge, but that didn't happen, so adjust some things to match the current 12-byte object header size on 32-bit, and introduce some ABI constants for the expected 32- and 64-bit object header sizes we can assert against so that we have some robustness when it eventually changes again. Implements rdar://problem/31768303.
@jckarter jckarter mentioned this pull request May 3, 2017
Merged
jckarter added a commit to jckarter/swift that referenced this pull request May 3, 2017
@jckarter
Support key paths on 32-bit platforms.
d87b019 
I had optimistically written the code here optimistically hoping swiftlang#7837 would land in time for me to merge, but that didn't happen, so adjust some things to match the current 12-byte object header size on 32-bit, and introduce some ABI constants for the expected 32- and 64-bit object header sizes we can assert against so that we have some robustness when it eventually changes again. Implements rdar://problem/31768303.
@jckarter jckarter mentioned this pull request May 3, 2017
Merged
@gparker42 gparker42 closed this Oct 18, 2017
@gparker42 gparker42 deleted the GrP-PR-23107E5F-1A70-433F-8B71-23632DA0D5C2 branch October 18, 2017 17:05
@gparker42
Copy link
Contributor Author

Reintroduced in #12790.

@gparker42 gparker42 mannequin mentioned this pull request Mar 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gparker42 @swift-ci