-
Notifications
You must be signed in to change notification settings - Fork 10.5k
build: enable the Android SDKs to be built, packaged, and tested #78410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@swift-ci please test Windows platform |
1 similar comment
@swift-ci please test Windows platform |
@swift-ci please build toolchain Windows platform |
Build and package the Android SDKs on Windows as part of the toolchain distribution. This requires further fine tuning to improve the DevEx, however, this ensures that we do not backslide on the ability to build and package the SDK as a starting point. Currently, we build for Android ARM64 only, but are likely to switch to X64 to get test coverage.
@swift-ci please smoke test |
PR test failed with:
Added 1 more XFAL in #80053. The XPASSes are in the filter already and should have been skipped. Not sure why it doesn't apply here. Same code works for LLDB. |
@swift-ci please test Windows platform |
CC: @shahmishal, @etcwilde This adds only the ARM64 slice for PR testing (we run through all the architectures on the nightly). |
@swift-ci please test Windows platform |
1 similar comment
@swift-ci please test Windows platform |
How much more time does this add to the build? |
@swift-ci please test Windows platform |
The build will add ~12m for the SDK, and the non-executable testing time (which fluctuates) |
Testing Time: 1266.55s
We are basically building a full Android SDK (Core Libraries, Overlays, Supplemental Libraries, libdispatch, Foundation, XCTest, Testing), building the new experimental runtime build, and running the non-executable tests. We could shave the time for the experimental runtime builds I suppose, but it takes about 23m to do the build and 21m to run the tests. We could reduce the build times down to 18m by skipping the new runtimes build. |
Build and package the Android SDKs on Windows as part of the toolchain distribution. This requires further fine tuning to improve the DevEx, however, this ensures that we do not backslide on the ability to build and package the SDK as a starting point.