[Concurrency] Fix a few issues with Senable and Any
#79382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…whether access is mutating or not Otherwise `inout` uses of declarations that require ABI safe conversions are going to be diagnosed as non-mutating.
…positions It should be possible to pass values with `any Sendable` as arguments to `inout` parameters that expect `Any`. This is pretty much the same as an l-value conversion. Resolves: swiftlang#79361 Resolves: rdar://144794132
…expressions This expands swiftlang#77510 to base expressions of calls, subscripts and members to make sure that if the base has `@preconcurrency` declaration at some level. Otherwise, the availability checker won't appropriately downgrade unavailable `Sendable` conformances for `@preconcurrency` declarations.
xedin
requested review from
jckarter,
ktoso,
hborla,
tshortli and
slavapestov
as code owners
|
swiftlang/swift-foundation#1169 |
|
swiftlang/swift-foundation#1169 |
hborla
approved these changes
Feb 14, 2025
|
@jmschonfeld and @bnbarham looks like sourcekit-lsp has |
…ignments If destination is marked as `@preconcurrency` the Sendable conformance errors should be downgraded to warnings even in Swift 6 mode just like for member and subscript references.
|
Turns out I mixed that up with another situation where |
|
swiftlang/swift-foundation#1169 |
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
ahoppen
added a commit
to ahoppen/swift-docc-symbolkit
that referenced
this pull request
Mar 8, 2025
…tion#1169 but not swiftlang/swift#79382. rdar://145669600
ahoppen
added a commit
to ahoppen/swift-docc-symbolkit
that referenced
this pull request
Mar 8, 2025
This fixes build failures for setups that have swiftlang/swift-foundation#1169 but not swiftlang/swift#79382. rdar://145669600
ahoppen
added a commit
to ahoppen/swift-docc-symbolkit
that referenced
this pull request
Mar 8, 2025
This fixes build failures for setups that have swiftlang/swift-foundation#1169 but not swiftlang/swift#79382. rdar://145669600
ahoppen
added a commit
to ahoppen/swift-docc-symbolkit
that referenced
this pull request
Mar 8, 2025
This fixes build failures for setups that have swiftlang/swift-foundation#1169 but not swiftlang/swift#79382. rdar://145669600
QuietMisdreavus
pushed a commit
to swiftlang/swift-docc-symbolkit
that referenced
this pull request
Mar 10, 2025
…e]` (#96) This fixes build failures for setups that have swiftlang/swift-foundation#1169 but not swiftlang/swift#79382. rdar://145669600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sendable-to-Any: Allow conversion when in
inoutpositionsIt should be possible to pass values with
any Sendableas argumentsto
inoutparameters that expectAny. This is pretty much the sameas an l-value conversion.
Make sure that @preconcurrency use is detected in base expressions
This expands [Concurrency] Handle self apply exprs when computing
@preconcurencyin the availability checker. #77510 to baseexpressions of calls, subscripts and members to make sure that if
the base has
@preconcurrencydeclaration at some level. Otherwise,the availability checker won't appropriately downgrade unavailable
Sendableconformances for@preconcurrencydeclarations.Resolves: #79361
Resolves: rdar://144794132