Upgrade swift-crypto and related packages #79391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
shahmishal
reviewed
Feb 17, 2025
| @@ -2822,6 +2822,7 @@ function Build-SourceKitLSP($Arch) { | |||
| TSC_DIR = (Get-HostProjectCMakeModules ToolsSupportCore); | |||
| LLBuild_DIR = (Get-HostProjectCMakeModules LLBuild); | |||
| ArgumentParser_DIR = (Get-HostProjectCMakeModules ArgumentParser); | |||
| SwiftASN1_DIR = (Get-HostProjectCMakeModules ASN1); | |||
shahmishal
approved these changes
Feb 17, 2025
|
@swift-ci build toolchain |
|
Many of the failures are related to and outdated swift-tools version (5.8.1) while swift-crypto now requires 5.9. |
|
@swift-ci build toolchain |
|
The current failures are caused by the following:
|
|
@swift-ci build toolchain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of swift-crypto has bugs in its CMakeLists.txt that prevents
linking on macOS under certain circumstances. Update swift-crypto to the latest
release with the fixes. Since the new swift-crypto has a dependency on swift-asn1
add it in any build scripts that use CMake so that the dependency can be found
and not vendored by the CMake build file at a misaligned version. Bump related
package swift-asn1 to the latest versions.