Skip to content

Reapply "Task names" (#79562) #79600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 8, 2025
Merged

Reapply "Task names" (#79562) #79600

merged 7 commits into from
Mar 8, 2025

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Feb 25, 2025 •
edited
Loading

This reverts the revert #79562 and brings back #77609 with the task names APIs.

The reason for the revert was source compatibility was slightly off during the move to gyb

rdar://88918762

@ktoso
Copy link
Contributor Author

ktoso commented Feb 25, 2025

@swift-ci please test source compatibility

@ktoso ktoso force-pushed the wip-task-names-compat branch from 3dfedf6 to 8315565 Compare February 25, 2025 02:58
@ktoso
Copy link
Contributor Author

ktoso commented Feb 25, 2025

@swift-ci please test source compatibility

@ktoso
Copy link
Contributor Author

ktoso commented Feb 25, 2025

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Feb 25, 2025

@swift-ci please test source compatibility

@ktoso
Copy link
Contributor Author

ktoso commented Feb 25, 2025

@swift-ci please build toolchain

@ktoso ktoso changed the title Reapply "Merge pull request #77609 from ktoso/wip-task-names" (#79562) Reapply "Task names" (#79562) Feb 25, 2025
@ktoso
Copy link
Contributor Author

ktoso commented Feb 25, 2025 •
edited
Loading

Ongoing source compat infra issues:


warning: 'swift-log': skipping cache due to an error: Couldn’t fetch updates from remote repositories:
    Auto configuration failed
    140704406080320:error:02FFF001:system library:func(4095):Operation not permitted:/AppleInternal/Library/BuildRoots/4b66fb3c-7dd0-11ef-b4fb-4a83e32a47e1/Library/Caches/com.apple.xbs/Sources/libressl/libressl-3.3/crypto/bio/bss_file.c:122:fopen('/private/etc/ssl/openssl.cnf', 'rb')
    140704406080320:error:20FFF002:BIO routines:CRYPTO_internal:system lib:/AppleInternal/Library/BuildRoots/4b66fb3c-7dd0-11ef-b4fb-4a83e32a47e1/Library/Caches/com.apple.xbs/Sources/libressl/libressl-3.3/crypto/bio/bss_file.c:127:
    140704406080320:error:0EFFF002:configuration file routines:CRYPTO_internal:system lib:/AppleInternal/Library/BuildRoots/4b66fb3c-7dd0-11ef-b4fb-4a83e32a47e1/Library/Caches/com.apple.xbs/Sources/libressl/libressl-3.3/crypto/conf/conf_def.c:202:
warning: 'swift-service-lifecycle': skipping cache due to an error: Couldn’t fetch updates from remote repositories:

@ktoso
Copy link
Contributor Author

ktoso commented Feb 25, 2025

@swift-ci please test source compatibility

@ktoso
Copy link
Contributor Author

ktoso commented Feb 25, 2025

@swift-ci please test

edymtt
edymtt approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@edymtt edymtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build system changes look good to me.

etcwilde
etcwilde reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build system changes look fine to me.
There are a few files where the ending newline was removed or just not inserted.

@ktoso
Copy link
Contributor Author

ktoso commented Feb 25, 2025

Thanks for checking! I still see issues with using the gyb generated funcs in the same module but we can revisit this at later point in time.

As soon as source compat suite works again I'll merge these

@ktoso
Copy link
Contributor Author

ktoso commented Feb 25, 2025

@swift-ci please test source compatibility

1 similar comment
@ktoso
Copy link
Contributor Author

ktoso commented Feb 26, 2025

@swift-ci please test source compatibility

@ktoso ktoso mentioned this pull request Mar 4, 2025
Merged
@ktoso ktoso force-pushed the wip-task-names-compat branch from 8315565 to c6aa1fd Compare March 4, 2025 03:59
@ktoso
Copy link
Contributor Author

ktoso commented Mar 4, 2025

@swift-ci please test

@ktoso
Copy link
Contributor Author

ktoso commented Mar 4, 2025

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset
@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Mar 5, 2025

@swift-ci please test macOS

@ktoso
Copy link
Contributor Author

ktoso commented Mar 5, 2025

Source compat issues are not due to this PR but SIL lifetime issues mostly it seems.

@ktoso ktoso mentioned this pull request Mar 6, 2025
Merged
@ktoso
Copy link
Contributor Author

ktoso commented Mar 6, 2025

@swift-ci please test

@ktoso
Copy link
Contributor Author

ktoso commented Mar 6, 2025

With the redeclaration notes fixed maybe this time can figure it out... Can't get the exact problem at desk heh

@ktoso
Copy link
Contributor Author

ktoso commented Mar 6, 2025

@swift-ci please test

@ktoso ktoso force-pushed the wip-task-names-compat branch from 6df289d to 7066cb3 Compare March 7, 2025 03:32
@ktoso ktoso force-pushed the wip-task-names-compat branch from 0903e36 to 195271e Compare March 7, 2025 03:36
@ktoso
Copy link
Contributor Author

ktoso commented Mar 7, 2025

Thanks to #79812 we now found the mistake, thank you @xedin !

@ktoso ktoso force-pushed the wip-task-names-compat branch from ba650d6 to e7254c8 Compare March 7, 2025 04:02
@ktoso
Copy link
Contributor Author

ktoso commented Mar 7, 2025

@swift-ci please test

@ktoso
Copy link
Contributor Author

ktoso commented Mar 7, 2025

foundationPackageTests.xctest: error while loading shared libraries: libFoundationEssentials.so: cannot open shared object file: No such file or directory

@ktoso ktoso force-pushed the wip-task-names-compat branch from e7254c8 to e051ac4 Compare March 7, 2025 09:13
@ktoso
Copy link
Contributor Author

ktoso commented Mar 7, 2025

@swift-ci please test

@ktoso
Copy link
Contributor Author

ktoso commented Mar 7, 2025

@swift-ci please test Linux

@ktoso ktoso merged commit fda7f53 into swiftlang:main Mar 8, 2025
5 checks passed
@ktoso ktoso deleted the wip-task-names-compat branch March 10, 2025 02:44
@ktoso ktoso mentioned this pull request Mar 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etcwilde etcwilde etcwilde left review comments

@edymtt edymtt edymtt approved these changes

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

@ahoppen ahoppen Awaiting requested review from ahoppen

@bnbarham bnbarham Awaiting requested review from bnbarham

@CodaFi CodaFi Awaiting requested review from CodaFi

@hamishknight hamishknight Awaiting requested review from hamishknight

@rintaro rintaro Awaiting requested review from rintaro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktoso @etcwilde @edymtt