utils: split Build-* into Build- and Test- - #80082
Merged
Merged
Conversation
Member
Author
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
@swift-ci please smoke test |
ahoppen
approved these changes
Mar 18, 2025
ahoppen
left a comment
ahoppen
left a comment
Member
There was a problem hiding this comment.
LGTM. I’ve wanted to do this as well but never got to it, so thanks for doing it 🙏🏽
etcwilde
approved these changes
Mar 18, 2025
Member
Author
|
@swift-ci please smoke test |
compnerd
enabled auto-merge
March 18, 2025 19:50
Member
Author
|
@swift-ci please test Windows platform |
Member
Author
|
@swift-ci please smoke test Linux platform |
Member
Author
|
@swift-ci please smoke test macOS platform |
The callee does not take any parameters, remove the extra leftover parameter.
Split up the test routines from the build routines. This is motivated by the desire to simplify (remove logic flow) and to help get more accurate timing data.
Split up the test routines from the build routines. This is motivated by the desire to simplify (remove logic flow) and to help get more accurate timing data.
Split up the test routines from the build routines. This is motivated by the desire to simplify (remove logic flow) and to help get more accurate timing data.
Split up the test routines from the build routines. This is motivated by the desire to simplify (remove logic flow) and to help get more accurate timing data.
Member
Author
|
@swift-ci please smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This series of changes formally splits up the build step functions into a build function and a test function. This will allow us to properly measure build times and test times as well as helps reduce complexity. Most of the build steps are now effectively a CMake invocation only.