[Dependency Scanning] Remove obsolete placeholder module concept#82031
Merged
Conversation
Contributor
Author
artemcm
force-pushed
the
RemovePlaceholdersInDepScanner
branch
from
17cf28d to
78ad677
Compare
Contributor
Author
artemcm
force-pushed
the
RemovePlaceholdersInDepScanner
branch
from
78ad677 to
0ff8d8e
Compare
Contributor
Author
Contributor
Author
Contributor
Author
|
@swift-ci test |
artemcm
force-pushed
the
RemovePlaceholdersInDepScanner
branch
from
0ff8d8e to
c47f096
Compare
Contributor
Author
|
@swift-ci test |
This was used a long time ago for a design of a scanner which could rely on the client to specify that some modules *will be* present at a given location but are not yet during the scan. We have long ago determined that the scanner must have all modules available to it at the time of scan for soundness. This code has been stale for a couple of years and it is time to simplify things a bit by deleting it.
artemcm
force-pushed
the
RemovePlaceholdersInDepScanner
branch
from
c47f096 to
a78ee29
Compare
Contributor
Author
|
@swift-ci test |
artemcm
requested review from
cachemeifyoucan,
hborla,
slavapestov,
tshortli,
xedin and
xymus
as code owners
Contributor
Author
|
ping for code review 🙏 |
xymus
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was used a long time ago for a design of a scanner which could rely on the client to specify that some modules will be present at a given location but are not yet during the scan. We have long ago determined that the scanner must have all modules available to it at the time of scan for soundness. This code has been stale for a couple of years and it is time to simplify things a bit by deleting it.