[6.3] OriginallyDefinedIn: always use 1.0 as the starting platform version for $ld$previous directives#87194
Open
nkcsgexi wants to merge 2 commits intoswiftlang:release/6.3from
Open
[6.3] OriginallyDefinedIn: always use 1.0 as the starting platform version for $ld$previous directives#87194nkcsgexi wants to merge 2 commits intoswiftlang:release/6.3from
nkcsgexi wants to merge 2 commits intoswiftlang:release/6.3from
Conversation
…for $ld$previous directives Before this change, we were sometimes using introductory platform version as the starting version where a symbol is considered belonging to the original binary. However, this is insufficient because backdeploying to a platform version prior to a symbol's introductory version can happen. When it happens, we should expect the moved symbol to be found in the moved-from library, not the moved-to one. Expecting the symbol to be found in the moved-to library can lead to crasher. Resolves: rdar://159408187
…wiftlang#85600 Resolves: rdar://165178683
Contributor
Author
|
@swift-ci please test |
mikeash
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation: Before this change, we were sometimes using introductory platform version as the starting version where a symbol is considered belonging to the original binary. However, this is insufficient because backdeploying to a platform version prior to a symbol's introductory version can happen. When it happens, we should expect the moved symbol to be found in the moved-from library, not the moved-to one. Expecting the symbol to be found in the moved-to library can lead to crasher.
Main branch PR: OriginallyDefinedIn: always use 1.0 as the starting platform version for $ld$previous directives #85600
Reviewed by: Mike Ash
Risks: Low
Test: Existing tests updated
Resolves: rdar://170243529