Sema: Disjunction pruning improvements#87220
Open
slavapestov wants to merge 12 commits intoswiftlang:mainfrom
Open
Sema: Disjunction pruning improvements#87220slavapestov wants to merge 12 commits intoswiftlang:mainfrom
slavapestov wants to merge 12 commits intoswiftlang:mainfrom
Conversation
slavapestov
requested review from
DougGregor,
adrian-prantl,
artemcm,
eeckstein,
hborla,
tshortli,
xedin and
xymus
as code owners
slavapestov
force-pushed
the
refactor-disjunction-pruning-transitive-conformance
branch
from
5c5f80d to
dc634f4
Compare
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please test source compatibility |
Contributor
Author
|
@swift-ci Please smoke test Linux |
1 similar comment
Contributor
Author
|
@swift-ci Please smoke test Linux |
Contributor
Author
|
@swift-ci Please test Windows |
Member
|
swiftlang/swift-llbuild#1023 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on top of #87193.
Implement more precise checks for various exotic conversions, such as lvalue and inout conversions. Also, redo the "transitive conformance" check in a more principled way, modeled after
simplifyTransitivelyConformsTo(). I was originally planning on then refactoringsimplifyTransitivelyConformsTo()to use the new utility method, but I don't see any tests in the suite that fail with it disabled, so to minimize risk further I'm mostly only touching code paths that run when disjunction pruning is on.Fixes rdar://50025491.