-
-
Notifications
You must be signed in to change notification settings - Fork 51
Support async/await and require Swift 5.5 #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* wip * Add sample * Remove prototype * Apply relative pointer patch for wasm * Update example code to test without capturing context * Remove prototype target * WIP * Update JSPromise interface * Add cxxLanguageStandard option * Strip unused headers * Update toolchain version * Exclude non-source files * Fix example project build * Update copy-header to download from remote source * Adopt JSPromise changes * Split Xcode support code * Add API documents * Adopt JSPromsie API change part2 * Add linguist-vendored * Update README * Revert JSObject changes
Things have been changed at all, so I need to make it re-work again 😅 |
Time Change: +1,391.25ms (13%) Total Time: 10,326.75ms
|
Fair enough, would it make sense to close this PR then? |
If you want to work on this, it makes sense to keep this open. If not, and no one will work on this, I'll do it in a different branch because most parts of this btanch are obsolete. |
I would love to work on this, I only hoped it could be done quickly 😅 But since it needs a rewrite, I will probably be too slow with this. Let's keep it open for now to show our intent if anyone wants to know about our plans for this. Can close this one when a separate branch/PR for a rewrite is needed. |
@kateinoigakukun have you seen error messages in CI runs here? They were caused by |
At first, my new PR doesn't bring headers from toolchain, so there is no issue around it. Then, think about the issue here. |
No description provided.