Skip to content

Export UnsafeEventLoopYield error type #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

kateinoigakukun
Copy link
Member

Some apps wrap instance.exports and monitor
exceptions thrown during execution of Wasm program but UnsafeEventLoopYield is not something they
want to report, so they need to be able to filter them out. However, they cannot use UnsafeEventLoopYield type name because some bundlers can rename it.
We should export it to allow them not to depend on the constructor name

Some apps wrap instance.exports and monitor
exceptions thrown during execution of Wasm program
but `UnsafeEventLoopYield` is not something they
want to report, so they need to be able to filter them
out. However, they cannot use `UnsafeEventLoopYield` type
name because some bundlers can rename it.
We should export it to allow them not to depend on the
constructor name
Copy link

github-actions bot commented Apr 9, 2025

Time Change: -290ms (3%)

Total Time: 9,618ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 26ms -2ms (8%)
Serialization/JavaScript function call through Wasm import with int 22ms -2ms (11%) 👏
Serialization/JavaScript function call from Swift 120ms -15ms (12%) 👏
Serialization/Swift Int to JavaScript with assignment 337ms -19ms (5%)
Serialization/Swift Int to JavaScript with call 963ms -52ms (5%)
Serialization/JavaScript Number to Swift Int 263ms -23ms (8%)
View Unchanged
Test name Duration Change
Serialization/Swift String to JavaScript with assignment 416ms -15ms (3%)
Serialization/Swift String to JavaScript with call 1,056ms -36ms (3%)
Serialization/JavaScript String to Swift String 3,589ms -107ms (2%)
Object heap/Increment and decrement RC 2,788ms -27ms (0%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 8ms
Serialization/Assign JavaScript number directly 8ms
Serialization/Call with JavaScript number directly 7ms
Serialization/Write JavaScript string directly 7ms
Serialization/Call with JavaScript string directly 7ms

@kateinoigakukun kateinoigakukun merged commit 935c5d9 into main Apr 9, 2025
7 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/export-yield-error-type branch April 9, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant