Skip to content

[WASM] Restore lost _withStackOrHeapBuffer implementation #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2020
Merged

[WASM] Restore lost _withStackOrHeapBuffer implementation #143

merged 1 commit into from
Oct 7, 2020

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Oct 6, 2020 •
edited
Loading

Resolve swiftwasm/swift#1824 (comment)

$ swift build -c debug --build-tests --destination wasm32-unknown-wasi.json 
wasm-ld: error: /path/to/swift-wasm-DEVELOPMENT-SNAPSHOT-2020-10-05-a/usr/lib/swift_static/wasi/libFoundation.a(Data.swift.obj): undefined symbol: _withStackOrHeapBuffer
clang-10: error: linker command failed with exit code 1 (use -v to see invocation)
<unknown>:0: error: link command failed with exit code 1 (use -v to see invocation)
[7/8] Linking wpkgPackageTests.xctest

@kateinoigakukun kateinoigakukun mentioned this pull request Oct 6, 2020
Closed
MaxDesiatov
MaxDesiatov approved these changes Oct 6, 2020
View reviewed changes
Copy link

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This was probably lost during my rushed merge not too long ago 🤦‍♂️

@MaxDesiatov MaxDesiatov added the bug Something isn't working label Oct 6, 2020
@kateinoigakukun
Copy link
Member Author

We need more e2e test cases and run CI on this repo to avoid bad conflict resolution.

@MaxDesiatov
Copy link

Absolutely! I've created swiftwasm/swift#1932 to track that.

@kateinoigakukun
Copy link
Member Author

I confirmed that linking Foundation works well with swiftwasm/swift#1931 toolchain

@kateinoigakukun kateinoigakukun merged commit 1b59649 into swiftwasm Oct 7, 2020
@kateinoigakukun kateinoigakukun deleted the katei/restore-_withStackOrHeapBuffer branch August 7, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building a test bundle fails with 5.3 snapshots
2 participants
@kateinoigakukun @MaxDesiatov